Adding unit tests to #278 #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and reverting the UI package upgrade as 3.1.1 has a bug
jmprieur
commented
Feb 9, 2020
| /Microsoft.Identity.Web.Test/obj | ||
| /4-WebApp-your-API/4-2-B2C/.vs | ||
| /4-WebApp-your-API/4-2-B2C/Client/obj | ||
| /4-WebApp-your-API/4-2-B2C/TodoListService/obj | ||
| /2-WebApp-graph-user/2-3-Multi-Tenant/.vs/WebApp-OpenIDConnect-DotNet |
There was a problem hiding this comment.
Was already present in the .gitignore
jmprieur
commented
Feb 9, 2020
| .editorconfig = .editorconfig | ||
| EndProjectSection | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Identity.Web.Test", "..\..\Microsoft.Identity.Web.Test\Microsoft.Identity.Web.Test.csproj", "{8CCEAE2A-BDF6-470C-B6DE-7FC81A74DBD7}" |
There was a problem hiding this comment.
Adding the unit tests assembly to the solution
jmprieur
commented
Feb 9, 2020
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="3.0.0" /> | |||
| <PackageReference Include="Microsoft.Graph" Version="1.14.0" /> | |||
| <PackageReference Include="Microsoft.Graph" Version="1.21.0" /> | |||
There was a problem hiding this comment.
Updating to the latest Graph SDK
jmprieur
commented
Feb 9, 2020
| @@ -53,8 +53,8 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="3.1.1" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureADB2C.UI" Version="3.1.1" /> | |||
| <PackageReference Include="Microsoft.AspNetCore.Authentication.AzureAD.UI" Version="3.0.0" /> | |||
There was a problem hiding this comment.
AzureADB2C.UI 3.1.1 has an issue.
jmprieur
commented
Feb 9, 2020
| if (!authority.EndsWith("v2.0")) | ||
| authority += "/v2.0"; | ||
| options.Authority = authority; | ||
| EnsureAuthorityIsV2_0(options); |
There was a problem hiding this comment.
Refactoring for testability
jmprieur
commented
Feb 9, 2020
| options.TokenValidationParameters.ValidAudiences = validAudiences; | ||
| // The valid audience could be given as Client Id or as Uri. | ||
| // If it does not start with 'api://', this variant is added to the list of valid audiences. | ||
| EnsureValidAudiencesContainsApiGuidIfGuidProvided(options); |
There was a problem hiding this comment.
Refactoring for testability
jennyf19
reviewed
Feb 10, 2020
jennyf19
reviewed
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding unit tests to #278 and reverting the UI package upgrade as 3.1.1 has a bug
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information